Open
Conversation
Enorovan
force-pushed
the
cclcc/menu-fog
branch
2 times, most recently
from
05e8d0d to
1e1482c
Compare
PringlesGang
approved these changes
Apr 8, 2026
Member
PringlesGang
left a comment
PringlesGang
left a comment
There was a problem hiding this comment.
Still doesn't use the same shader/blend mode, but that can also come in a different PR I suppose
Comment on lines
+63
to
+67
| UI::CCLCC::SystemMenu* menu = new UI::CCLCC::SystemMenu(); | ||
|
|
||
| menu->SmokeAnimation.LoopMode = AnimationLoopMode::Loop; | ||
| menu->SmokeAnimation.DurationIn = SmokeAnimationDurationIn; | ||
| menu->SmokeAnimation.DurationOut = SmokeAnimationDurationOut; |
Member
There was a problem hiding this comment.
The menu pointer is already created and pushed a couple lines below? The durations are also already set in the constructor
Comment on lines
+26
to
+31
| inline float SmokeX; | ||
| inline float SmokeY; | ||
| inline float SmokeBoundsX; | ||
| inline float SmokeBoundsY; | ||
| inline float SmokeBoundsWidth; | ||
| inline float SmokeBoundsHeight; |
Member
There was a problem hiding this comment.
Just use a glm::vec2 and a RectF
| glm::vec2(SmokeBoundsWidth - (SmokeAnimationBoundsXMax * | ||
| (1.0f - SmokeAnimation.Progress)), | ||
| SmokeY), | ||
| col); |
Member
There was a problem hiding this comment.
I don't really like the idea of modifying this profile variable's bounds...
I'd make a local copy of the sprite and modify that instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.